Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCFS-1207: Update fuel type for other_uses #1411

Merged
merged 6 commits into from
Dec 11, 2024

Conversation

areyeslo
Copy link
Collaborator

@areyeslo areyeslo commented Dec 9, 2024

Fuel type for other uses should be the following:

  • Alternative Jet Fuel
  • Biodiesel
  • Ethanol
  • Fossil-Derived Diesel
  • Fossil-Derived Gasoline
  • Fossil-Derived Jet Fuel
  • HDRD (Hydrotreated Renewable Diesel)
  • Other Diesel Fuel
  • Renewable Gasoline

image

Story

Copy link

github-actions bot commented Dec 9, 2024

Backend Test Results

493 tests  ±0   493 ✅ ±0   1m 47s ⏱️ ±0s
  1 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 0253e2a. ± Comparison against base commit 52407c7.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Dec 9, 2024

Frontend Test Results

  1 files  ±0  116 suites  ±0   37s ⏱️ ±0s
388 tests ±0  368 ✅ ±0  20 💤 ±0  0 ❌ ±0 
390 runs  ±0  370 ✅ ±0  20 💤 ±0  0 ❌ ±0 

Results for commit 0253e2a. ± Comparison against base commit 52407c7.

♻️ This comment has been updated with latest results.

@areyeslo areyeslo force-pushed the LCFS-1207-Changes-FuelOtherUse branch from 9c06e6e to 732e484 Compare December 9, 2024 23:44
@areyeslo areyeslo requested a review from AlexZorkin December 9, 2024 23:52
@kuanfandevops kuanfandevops added build and removed build labels Dec 10, 2024
@areyeslo areyeslo force-pushed the LCFS-1207-Changes-FuelOtherUse branch 3 times, most recently from 77f163f to 2fc7a88 Compare December 11, 2024 18:53
@areyeslo areyeslo force-pushed the LCFS-1207-Changes-FuelOtherUse branch from 2fc7a88 to d13cd66 Compare December 11, 2024 19:24
Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this ticket it was required to add 3 new columns to the other_use table in the frontend. Was this completed in a separate ticket?

@@ -11,7 +11,7 @@

# revision identifiers, used by Alembic.
revision = "cd8698fe40e6"
down_revision = "9206124a098b"
down_revision = "7ae38a8413ab"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please double check this migration id is in the correct order.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating this another migration appeared before mine.

@areyeslo
Copy link
Collaborator Author

areyeslo commented Dec 11, 2024

The addition of the fields was already merged #1269
This is a follow up ticket. The details are included in the description.

Copy link
Collaborator

@AlexZorkin AlexZorkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@areyeslo areyeslo merged commit 85c783d into release-0.2.0 Dec 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants